[common-go] continue on hashConfig errors #20752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylos101
changed the title
geropl
reviewed
Apr 16, 2025
This reverts commit e43e0d8.
This way, subsequent changes to the watched file may be honored
kylos101
changed the title
|
Testing again for posterity: The change at 16:38 is because of a patch, the prior changes on the 30m mark are from a cronjob. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used to return and stop watching a file if the hashConfig function returned an error. Now we log the error (including the event name) so we can later try again on subsequent fsnotify events.
Related Issue(s)
Fixes CLC-1304
How to test
Update the
image-pull-secretin this preview environment, and assert that file watcher picks up the new value in the logs.In the below picture, you'll see 3 entries, 1 for the initial start and 2 where I changed the secret value path via:
kubectl patch secret image-pull-secret --patch '{"data":{".dockerconfigjson":"'$(cat patch.json | base64 -w 0)'"}}'Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold